Disable "use_static_cpp" when "use_hot_reload" is enabled #1877
+2
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
commenting on the right pr this time i hope
You're right of course. set(STATIC_CPP "$<AND:$<BOOL:${GODOTCPP_USE_STATIC_CPP}>,$<NOT:$<BOOL:${GODOTCPP_USE_HOT_RELOAD}>>>")CMake generator expressions are so ugly, cmake in general is ugly, but the generator expressions are next level ugly. set(NOT_RELOAD "$<NOT:$<BOOL:${GODOTCPP_USE_HOT_RELOAD}>>"
set(STATIC_CPP "$<AND:$<BOOL:${GODOTCPP_USE_STATIC_CPP}>,${NOT_RELOAD}>") |
Collaborator
Author
|
Superseded by #1878 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1876
This implements option nr 3 from that issue, but I wonder if option nr 1 would be better?
This PR ends up creating an inconsistency by default, where the debug template is built with
use_static_cpp=noand the release template is built withuse_static_cpp=yesPerhaps this is the worst of all worlds?